Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome-129): show issue page #157

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

samdenty
Copy link
Member

@samdenty samdenty commented Oct 7, 2024

This makes people aware of #86 (comment)

CleanShot 2024-10-07 at 14 53 48@2x

Nemikolh
Nemikolh previously approved these changes Oct 7, 2024
Copy link
Member

@Nemikolh Nemikolh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just a minor comment

vite.config.ts Outdated Show resolved Hide resolved
Nemikolh
Nemikolh previously approved these changes Oct 7, 2024
Copy link
Contributor

@d3lm d3lm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

vite.config.ts Outdated Show resolved Hide resolved
Co-authored-by: Dominic Elm <[email protected]>
@samdenty samdenty enabled auto-merge (squash) October 7, 2024 14:19
@samdenty samdenty merged commit d0828e4 into main Oct 7, 2024
2 checks passed
@samdenty samdenty deleted the fix/vite-chrome-129-issue branch October 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants