Tests for CIS 194 homework assignments (1 to 6) #8

ghost · 2017-02-15T22:49:49Z

I have added tests based in homeworks (1 to 6) of CIS 194 course. The reason for this pull request is that all tests that use doctest package exists. The doctest package definition is:

The doctest program checks examples in source code comments. It is modeled after doctest for Python.

It can cause confusion at the time of run tests, because usually tests source code are in other files and folders. I think that a better practice is to use a testing package for this tests. I choosed hspec package because I found this package in some Stack Builders repositories. The hspec package definition is:

Hspec is a testing framework for Haskell. It is inspired by the Ruby library RSpec.

I have used hspec package to migrate doctest tests to this testing framework.

Please check these tests and write any commentary if is necessary.

juanpaucar · 2017-02-17T14:19:54Z

homework01/test/examples/Main.hs

@@ -1,15 +1,44 @@
-module Main
-  ( main


I think we should keep this to be explicit about what the module exports

Ok, no problem 👍

juanpaucar · 2017-02-17T14:21:48Z

homework01/test/examples/Main.hs

-    ]
+main = hspec $ do
+
+  describe "toDigits" $ do


Not sure if it's important, but what about the case for numbers starting with 0 like 01234

The signature of toDigits function is toDigits :: Integer -> [Integer]. Haskell don't use leading zeros, so toDigits 01234 == toDigits 1234.

juanpaucar · 2017-02-17T14:23:15Z

homework01/test/examples/Main.hs

+    it "returns an empty list for negative inputs" $
+      toDigits (-17) `shouldBe` []
+
+  describe "toDigitsRev" $


What does this function makes if a negative number is passed as argument? and like before, not sure if important but what if the number starts with 0

Checking homework 01, toDigitsRev function has the same tests as toDigits function, I'm going to add the corresponding tests.

juanpaucar · 2017-02-17T14:27:53Z

homework01/test/examples/Main.hs

+    it "converts positive integers to a list of digits reversed" $
+      toDigitsRev 1234 `shouldBe` [4, 3, 2, 1]
+
+  describe "doubleEveryOther" $ do


Not sure if important, but what happens with an empty list?

I'm not sure if it's necessary to add a test with an empty lists as input, because the exercise doesn't indicate this kind of input. I know that is necessary to test all cases (valid and invalid inputs) but this can produce confusion in a Haskell beginner when he test doubleEveryOther function and don't pass a test with an empty list.

juanpaucar · 2017-02-17T14:29:08Z

homework02/test/examples/Main.hs

@@ -1,15 +1,39 @@
-module Main
-  ( main


Again, I think it's a better idea to keep specific what the module exports

Solved 👍

juanpaucar · 2017-02-17T14:48:24Z

homework05/test/examples/Main.hs

@@ -1,15 +1,61 @@
-module Main
-  ( main


same as above, let's keep being specific about what a module exports

Solved 👍

juanpaucar · 2017-02-17T14:53:36Z

homework05/test/examples/Main.hs

+    it "evaluates expression without parenthesis" $
+      evalStr "2+3*4" `shouldBe` Just 14
+
+    it "evaluates wrong expression" $


can we make a case for a negative number too?

I'm going to modify this tests to consider operations with negative numbers.

juanpaucar · 2017-02-17T14:56:44Z

homework05/test/examples/Main.hs

+        let testSat = parseExp lit add mul "(3 * 4) + (-5)" :: Maybe Mod7
+        testSat `shouldBe` Just (Mod7 0)
+
+  describe "compile" $


what happens with incorrect input?

parseExp function in Parser.hs file handles this case, producing Nothing for the inputs which are not well-formed expressions.

juanpaucar · 2017-02-17T14:57:05Z

homework06/test/examples/Main.hs

@@ -1,15 +1,45 @@
-module Main
-  ( main


same as above about what the module exports

Solved 👍

juanpaucar · 2017-02-17T14:58:12Z

homework05/test/examples/Main.hs

+
+  describe "reify" $
+    it "makes an instance of Expr to ExprT type" $
+      reify (mul (add (lit 2) (lit 3)) (lit 4)) `shouldBe` ExprT.Mul (ExprT.Add (ExprT.Lit 2) (ExprT.Lit 3)) (ExprT.Lit 4)


please, split this line to make it more readable

flandrade

@jmorocho Good job. I left some comments. Could you please take a look? Thanks for your contribution!

In addition, could you please run hlint?

flandrade · 2017-02-17T22:17:36Z

homework02/test/examples/Main.hs

+  describe "whatWentWrong" $
+    it "returns a list of the messages corresponding to any errors with a severity of 50 or greater, sorted by timestamp" $
+      pendingWith " whatWentWrong returns IO [String]"
+      -- testWhatWentWrong parse whatWentWrong "src/sample.log" `shouldBe` ["Way too many pickles","Bad pickle-flange interaction detected","Flange failed!"]


@jmorocho Could you please remove this comment? Thanks.

Ok, no problem 👍

flandrade · 2017-02-21T14:49:58Z

homework01/test/examples/Main.hs

+
+      it "gets a list of moves whit 3 discs" $
+        hanoi 3 "a" "b" "c" `shouldBe` [("a","b"),("a","c"),("b","c"),("a","b"),("c","a"),("c","b"),("a","b")]
+


@jmorocho Could you please add a EOF space?

Ok, no problem 👍

flandrade · 2017-02-21T14:51:15Z

homework02/test/examples/Main.hs

+    it "returns a list of the messages corresponding to any errors sorted by timestamp" $
+      pendingWith "whatWentWrong returns IO [String]"
+      -- testWhatWentWrong parse whatWentWrong "src/sample.log" 
+          -- `shouldBe` ["Way too many pickles","Bad pickle-flange interaction detected","Flange failed!"]


@jmorocho Could you please remove this comment?

Ok, no problem 👍

I have written the test of this function. Check please.

flandrade · 2017-02-21T14:59:22Z

homework01/test/examples/Main.hs

+main = hspec $ do
+
+  describe "toDigits" $ do
+    it "converts positive integers to a list of digits" $


@jmorocho Some of these describe a context. Could you please verify and add context? http://hspec.github.io/writing-specs.html

describe "toDigits" $ do context "when digits are positive integers" $ do it "converts to a list of digits" $ do

You are right, the context is when digits are positive integers. I going to change this.

flandrade

@jmorocho Good job so far. I left some comments regarding the use of context. This might be helpful: http://lmws.net/describe-vs-context-in-rspec

flandrade · 2017-02-22T15:02:35Z

homework01/test/examples/Main.hs

+      sumDigits [16, 7, 12, 5] `shouldBe` 22
+
+  describe "validate" $ do
+    it "returns True if an Integer is a valid credit card number" $


@jmorocho What about the following?

context "when the credit card number is valid it "returns True"

I changed the context in case of valid an invalid credit card number.

flandrade · 2017-02-22T15:04:00Z

homework03/test/examples/Main.hs

+    it "finds local maxima and gets 1 elements" $
+      localMaxima [2,3,4,1,5] `shouldBe` [4]
+
+    it "finds local maxima and not gets elements" $


@jmorocho "find local maxima and doesn't get elements"?

In addition, I think we're missing some context functions here. Why in some case do you get one element or two?

context "list.... " it "gets 2 elements"

Context added in case that exists at least one local maximum or none.

flandrade · 2017-02-22T15:07:30Z

homework04/test/examples/Main.hs

+    it "returns xor from a list with an odd number of True values" $
+      xor [False, True, False] `shouldBe` True
+
+    it "returns xor from a list with an even number of True values" $


@jmorocho context when list has an even number of elements?

Context added.

flandrade · 2017-02-22T15:09:17Z

homework05/test/examples/Main.hs

+      eval (ExprT.Mul (ExprT.Add (ExprT.Lit 2) (ExprT.Lit 3)) (ExprT.Lit (-4))) `shouldBe` (-20)
+
+  describe "evalStr" $ do
+    it "evaluates expression with parenthesis" $


@jmorocho What about the following?

context "when an expression has parenthesis" $ do it "evaluates the expression"

Added two nested contexts because when the expression is well-formed (with or without parentheses), the function return value of the expression and when the expression is not well-formed (with or without parentheses), return Nothing.

flandrade · 2017-02-22T15:11:37Z

homework05/test/examples/Main.hs

+        `shouldBe` ExprT.Mul (ExprT.Add (ExprT.Lit 2) (ExprT.Lit 3)) (ExprT.Lit (-4))
+
+  describe "parseExp" $
+    context "when provided with multiple data types" $ do


@jmorocho I think it's better to have multiple contexts here. For example:

context "when provided with an Integer data type" $ do it "evaluates the expression"

What do you think?

Your are right, this test have multiple contexts (Integer, Bool, etc.).

flandrade · 2017-02-22T15:13:34Z

homework05/test/examples/Main.hs

+      compile "(3*4)" `shouldBe` ((Just [PushI 3,PushI 4,StackVM.Mul]) :: Maybe Program)
+
+  describe "withVars" $ do
+    it "evaluates all expression if variable exist in a operation of Expr class" $


@jmorocho What about the following?

context "when the provided variable exists in an operation of Expr class" $ do it "evaluates the expression"

Good suggestion, thanks 👍

flandrade · 2017-02-22T15:16:25Z

homework01/test/examples/Main.hs

+      it "converts to a list of digits reversed" $ 
+        toDigitsRev 9876 `shouldBe` [6, 7, 8, 9]
+
+      it "returns an empty list for 0" $


@jmorocho I think we're missing some context functions. Perhaps:

context "when the digit is 0" it "returns an empty list"

Yes, is a good suggestion.

flandrade · 2017-02-22T15:18:04Z

homework01/test/examples/Main.hs

+        toDigitsRev (-1) `shouldBe` []
+
+  describe "doubleEveryOther" $ do
+    it "doubles every other number beginning from the right (even number of elements)" $


@jmorocho Perhaps:

context "when the list has an even number of elements" it "doubles every other number beginning from the right"

Could you please verify for each case of doubleEveryOther?

juanpaucar suggested changes Feb 17, 2017

View reviewed changes

flandrade requested changes Feb 21, 2017

View reviewed changes

flandrade reviewed Feb 22, 2017

View reviewed changes

Add tests for homework 1 to 6 using hspec package.

85357b0

ghost changed the title ~~Tests for CIS 194 homeworks~~ Tests for CIS 194 homeworks 1 to 6 Mar 29, 2017

ghost changed the title ~~Tests for CIS 194 homeworks 1 to 6~~ Tests for CIS 194 homework 1 to 6 Mar 29, 2017

ghost changed the title ~~Tests for CIS 194 homework 1 to 6~~ Tests for CIS 194 homework assignments (1 to 6) Mar 29, 2017


		it "gets a list of moves whit 3 discs" $
		hanoi 3 "a" "b" "c" `shouldBe` [("a","b"),("a","c"),("b","c"),("a","b"),("c","a"),("c","b"),("a","b")]

Tests for CIS 194 homework assignments (1 to 6) #8

Are you sure you want to change the base?

Tests for CIS 194 homework assignments (1 to 6) #8

Conversation

ghost commented Feb 15, 2017 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juanpaucar Feb 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juanpaucar Feb 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flandrade left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flandrade left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flandrade Feb 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flandrade Feb 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flandrade Feb 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Feb 15, 2017 •

edited by ghost

Loading

juanpaucar Feb 17, 2017 •

edited

Loading

juanpaucar Feb 17, 2017 •

edited

Loading

flandrade left a comment •

edited

Loading

flandrade Feb 22, 2017 •

edited

Loading

flandrade Feb 22, 2017 •

edited

Loading

flandrade Feb 22, 2017 •

edited

Loading