Wallet send+recv status derived from logs #1559
Draft
+227
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
changed the title
ekzyis
force-pushed
the
wallet-logs-status
branch
2 times, most recently
from
2ed4391
to
fc316a6
Compare
1 task
ekzyis
force-pushed
the
wallet-logs-status
branch
3 times, most recently
from
c1ccff1
to
ce852dd
Compare
ekzyis
force-pushed
the
wallet-logs-status
branch
from
3d10b62
to
e6d84d0
Compare
ekzyis
commented
Nov 14, 2024
| @@ -27,6 +27,14 @@ export default function LogMessage ({ showWallet, wallet, level, message, contex | |||
|
|
|||
| const style = hasContext ? { cursor: 'pointer' } : { cursor: 'inherit' } | |||
| const indicator = hasContext ? (show ? '-' : '+') : <></> | |||
| const filteredCtx = context | |||
There was a problem hiding this comment.
we don't want to show send or recv in the context of a log message
ekzyis
commented
Nov 14, 2024
| @@ -11,7 +11,7 @@ export default function WalletButtonBar ({ | |||
| return ( | |||
| <div className={`mt-3 ${className}`}> | |||
| <div className='d-flex justify-content-between'> | |||
| {isConfigured(wallet) && | |||
| {isConfigured(wallet) && wallet.def.requiresConfig && | |||
There was a problem hiding this comment.
I don't like that WebLN always showed detach. This fixes it by only showing it if there's actually something to delete.
ekzyis
commented
Nov 14, 2024
| @@ -8,7 +8,7 @@ export async function testSendPayment ({ url, adminKey, invoiceKey }, { logger } | |||
| url = url.replace(/\/+$/, '') | |||
| await getWallet({ url, adminKey, invoiceKey }) | |||
|
|
|||
| logger.ok('wallet found') | |||
| logger.info('wallet found') | |||
There was a problem hiding this comment.
I didn't want this to affect the wallet status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, this simply uses the most recent log that isn't just info to derive the status.
Close #1490 Based on #1588 Related to #1495
TODO:
refactor workaround for conditional polling of wallet logs viauseIntervalmaybe it's not as dumb as I initially thought since alternatives look dumberno longer neededfix logging payments (see Fix first IDB operation never executed #1588 (comment))I decided to simply also use polling logs for wallet status so no code change needed.Screenshots
Video
2024-11-14.03-25-12.mp4
Additional Context
more than this:
even though it started as an accident.
I am setting
context.recv = truein thewalletLogger(the function) such that every log in the db will haverecv: trueinserted in the database. We could instead rely on!context.sendor simply addcontext.recvto all logs before returning them to the client.Aspect ratio of logos are different but all images use
width='100%'which means that an image with a higher height/width ratio might appears bigger. Good example is the LND logo on the config page since it's more a square. SoChecklist
Are your changes backwards compatible? Please answer below:
yes,
context.sendorcontext.recvis only used to derive wallet statusOn a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. See video for Q&A.For frontend changes: Tested on mobile? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no