Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete profiles before deleting project #3561

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Delete profiles before deleting project #3561

merged 2 commits into from
Jun 10, 2024

Conversation

dmjb
Copy link
Member

@dmjb dmjb commented Jun 7, 2024

This avoids an issue which Ozz ran into where the ON CASCADE DELETE relationships would attempt to delete rows from rule_type before deleting from rule_instances. This would fail because there is a foreign key relation from rule_instances to rule_type which prevents deletion of in-use rule types.

The old entity_profile_rules table had a foreign key reference to rule_type marked as ON DELETE CASCADE, and relied on logic in the code to prevent the deletion of rule instances which are in use.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This avoids an issue which Ozz ran into where the `ON CASCADE DELETE`
relationships would attempt to delete rows from rule_type before
deleting from rule_instances. This would fail because there is a foreign
key relation from rule_instances to rule_type which prevents deletion of
in-use rule types.

The old entity_profile_rules table had a foreign key reference to
rule_type marked as `ON DELETE CASCADE`, and relied on logic in the code
to prevent the deletion of rule instances which are in use.
@dmjb dmjb requested a review from a team as a code owner June 7, 2024 14:41
@coveralls
Copy link

Coverage Status

coverage: 53.132% (-0.005%) from 53.137%
when pulling 836440a on delete-profiles-first
into 75dcc45 on main.

@dmjb dmjb merged commit f7fa491 into main Jun 10, 2024
21 checks passed
@dmjb dmjb deleted the delete-profiles-first branch June 10, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants