Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unneeded Registered field #3563

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

ChrisJBurns
Copy link
Contributor

@ChrisJBurns ChrisJBurns commented Jun 8, 2024

Summary

The Registered field in Repository was not being used anywhere and given that Repository is only used to represent registered repositories, we should remove it.

Fixes #2628

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

From initial looks, the field was not being used therefore not influencing tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling 5ae6b4d on ChrisJBurns:main
into 75dcc45 on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 53.143% (+0.006%) from 53.137%
when pulling 5ae6b4d on ChrisJBurns:main
into 75dcc45 on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling c4c711e on ChrisJBurns:main
into 75dcc45 on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling 7513600 on ChrisJBurns:main
into 75dcc45 on stacklok:main.

@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling ffcf69e on ChrisJBurns:main
into 75dcc45 on stacklok:main.

The `Registered` field in `Repository` was not being used anywhere and given that `Repository` is only used to represent registered repositories, we should remove it.

Signed-off-by: ChrisJBurns <[email protected]>
@coveralls
Copy link

Coverage Status

coverage: 53.137%. remained the same
when pulling 39b4de1 on ChrisJBurns:main
into 75dcc45 on stacklok:main.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we may have originally intended to use Repository in ListRemoteRepositoriesFromProvider, but we changed that to use an UpstreamRepositoryRef, so this is, indeed, unused.

@evankanderson evankanderson merged commit 5539321 into stacklok:main Jun 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The repository registered field is not set
3 participants