Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encoding/csv to when parsing selector record #4515

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Use encoding/csv to when parsing selector record #4515

merged 3 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Use encoding/csv to when parsing selector record 

    `encoding/csv` allows us to handle selectors with commas in them which
our naive parser embarassingly didn't such as:
```
repository.properties['github/primary_language'] in ['TypeScript', 'Go'
```

Fixes: stacklok#4514
    @jhrozek
    jhrozek committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f46e054 View commit details
    Browse the repository at this point in the history

  2. Enable LazyQuotes in the CSV parser to handle uneven quoting

    @jhrozek
    jhrozek committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9e83fb0 View commit details
    Browse the repository at this point in the history

  3. Use backticks to avoid escaping quotes

    @jhrozek
    jhrozek committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    161cf63 View commit details
    Browse the repository at this point in the history