Simplify the attributes sent to the entity_add handler #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blkt would you mind reviewing this? You probably know the code better than I |
JAORMX
reviewed
Sep 17, 2024
| if repoName, ok = event.Entity["repoName"].(string); !ok { | ||
| return errors.New("invalid repo name") | ||
| if entName, ok = event.Entity[properties.PropertyName].(string); !ok { | ||
| return fmt.Errorf("invalid or unset entity name: %s", entName) |
There was a problem hiding this comment.
Will this continue using the name? Or will this switch to using the upstream ID?
There was a problem hiding this comment.
interesting idea, this code goes to repositories.CreateRepository which uses the name as a property for RetrieveAllProperties. I'm not sure if that and especially the underlying code supports retrieving a repo by name. I need to check that.
There was a problem hiding this comment.
It's not a big deal what property is used, as long as we use properties and not tie something to names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have a rather large branch that works towards not using database access from
the webhook handler. These two patches were part of that branch and can be submitted separately.
The aim is to decrease the number of attributes we send to the handler as well
as make them more generic.
Related: #4327
Change Type
Testing
as part of a larger branch + unit tests
Review Checklist: