Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github/pull_author_login as a property for PRs #4535

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 18, 2024

Summary

This allows us to write selectors like:

selection:
  - entity: pull_request
    selector: pull_request.properties['github/pull_author_login'] != 'jhrozek'
    comment: "We trust Jakub. Don't check his PRs"

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

manually

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This allows us to write selectors like:
```
selection:
  - entity: pull_request
    selector: pull_request.properties['github/pull_author_login'] != 'jhrozek'
    comment: "We trust Jakub. Don't check his PRs"
```
@coveralls
Copy link

Coverage Status

coverage: 52.821% (-0.002%) from 52.823%
when pulling 6d55224 on jhrozek:pr_prop_author_name
into 31a94e0 on stacklok:main.

@jhrozek jhrozek merged commit 8a591d6 into stacklok:main Sep 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants