Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint by provider class to the refreshAndDo handler #4558

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 20, 2024

Summary

This will be useful for the gitlab provider

Fixes: #4557

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This will be useful for the gitlab provider

Fixes: stacklok#4557
@JAORMX JAORMX merged commit 30c7d19 into stacklok:main Sep 20, 2024
20 checks passed
@coveralls
Copy link

coveralls commented Sep 20, 2024

Coverage Status

coverage: 53.167% (+0.001%) from 53.166%
when pulling a735323 on jhrozek:add_class_hint
into 04921fb on stacklok:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add provider class as a hint when looking up by upstream ID
3 participants