Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept traits on create central #1689

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

parametalol
Copy link
Contributor

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

Create central with:

me@work $ curl -X POST -H "Authorization: Bearer $(ocm token)" -H "Content-Type: application/json" \
  http://127.0.0.1:8000/api/rhacs/v1/centrals\?async\=true \
  -d '{"name": "'"${name}"'", "multi_az": true, "cloud_provider": "standalone", "region": "standalone", "traits": ["trait1","trait2"]}'

List centrals:

{
  "kind": "CentralList",
  "page": 1,
  "size": 1,
  "total": 1,
  "items": [
    {
      "id": "cnj1so2afmud6k403p10",
      "kind": "CentralRequest",
      "href": "/api/rhacs/v1/centrals/cnj1so2afmud6k403p10",
      "status": "preparing",
      "cloud_provider": "standalone",
      "multi_az": true,
      "region": "standalone",
      "owner": "[email protected]",
      "name": "test-central-3",
      "host": "acs-cnj1so2afmud6k403p10.cluster.local",
      "created_at": "2024-03-04T19:17:52.119201Z",
      "updated_at": "2024-03-04T19:17:57.623438Z",
      "instance_type": "eval",
      "traits": [
        "trait1",
        "trait2"
      ]
    }
  ]
}

Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 0x656b694d
Once this PR has been reviewed and has the lgtm label, please assign ludydoo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@parametalol parametalol requested a review from ludydoo March 4, 2024 19:21
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented May 28, 2024

@0x656b694d: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 20077bc link true /test images
ci/prow/e2e 20077bc link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants