Enable dynamic RHCOS tests #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbycochran
force-pushed
the
rc-rhcos-tests
branch
from
0cc751e
to
e2a5793
Compare
robbycochran
force-pushed
the
rc-rhcos-tests
branch
from
e2a5793
to
330f225
Compare
robbycochran
force-pushed
the
rc-rhcos-tests
branch
from
330f225
to
136cafc
Compare
Stringy
reviewed
Jun 6, 2024
ansible/group_vars/all.yml
Outdated
| @@ -63,8 +63,11 @@ virtual_machines: | |||
| rhcos: | |||
| project: rhcos-cloud | |||
| images: | |||
| - rhcos-412-86-202303211731-0-gcp-x86-64 | |||
| - rhcos-413-86-202303151429-0-gcp-x86-64 | |||
| - "{{ lookup('ansible.builtin.pipe', 'group_vars/fetch_ocp_rhcos_bootimage.sh 4.17') }}" | |||
There was a problem hiding this comment.
When these VMs are created, it's difficult to distinguish between them due to the name hashing (which is required primarily to keep names within GCP's 64 character limit.)
ok: [collector-ci-rhcos-core-054dab5c]
ok: [collector-ci-rhcos-core-084a4a5e]
ok: [collector-ci-rhcos-core-17637829]
ok: [collector-ci-rhcos-core-341de47b]
ok: [collector-ci-rhcos-core-8c21e427]
Not something to fix now, but just a note for myself to investigate a better solution when I have time.
There was a problem hiding this comment.
Can we move this to a scripts directory to avoid having non-variable files in group_vars?
Stringy
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rhcosimages associated with ocp installer bootimagerhelGCP image families on PRsAdds images for OCP 4.14-4.17 on x86
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI-sufficient