Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Falco's stats v2 to zoom into the events drop metrics and split it into drops due to full buffers vs due to full thread cache.
There was some concern enabling the stats v2 portion of Falco would cause some unwanted procfs scraping from the following functions:
However, after inspecting the code and testing with GDB, it became clear those functions are only called from the
snapshot
function, so no additional procfs scrapping is added in the way we are using it.Part of ROX-24691.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Since this is a change to metrics, automated testing is not strictly required. As such, changes were tested manually by:
ROX_COLLECTOR_SINSP_THREAD_CACHE_SIZE
and theROX_COLLECTOR_SINSP_BUFFER_SIZE
, setting them to low values one at a time.:8080/ready
or:9090/metrics
endpoints.