Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stats v2 #1708

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Enable stats v2 #1708

merged 5 commits into from
Jun 17, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Jun 12, 2024

Description

Use Falco's stats v2 to zoom into the events drop metrics and split it into drops due to full buffers vs due to full thread cache.

There was some concern enabling the stats v2 portion of Falco would cause some unwanted procfs scraping from the following functions:

However, after inspecting the code and testing with GDB, it became clear those functions are only called from the snapshot function, so no additional procfs scrapping is added in the way we are using it.

Part of ROX-24691.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

Since this is a change to metrics, automated testing is not strictly required. As such, changes were tested manually by:

  • Running the new image as part of a stackrox deployment.
  • Edit the collector daemonset to include the ROX_COLLECTOR_SINSP_THREAD_CACHE_SIZE and the ROX_COLLECTOR_SINSP_BUFFER_SIZE, setting them to low values one at a time.
  • Run berserker in a container to add some strain to the system.
  • Check the new metrics are working as expected by using curl to query the :8080/ready or :9090/metrics endpoints.

@Molter73 Molter73 requested a review from a team as a code owner June 12, 2024 15:11
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Molter73 Molter73 merged commit 2951e8c into master Jun 17, 2024
47 checks passed
@Molter73 Molter73 deleted the feature/metrics-v2 branch June 17, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants