Remove WARNING health status for ppc64le VMs #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will mean that VMs must be fully created and stable before we communicate with them
|
Can we get a description on why we need this change? It's pretty ambiguous other wise, not sure if it's needed or if it's just a nice to have for instance. |
|
I have updated the description with some explanation about why we're removing it. TL;DR attempts at speeding up VM creation on Power were successful in testing, but are now consistently failing on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WARNING health status was added in an attempt to speed up ppc64le provisioning by shortcutting the creation process, allowing us to try to communicate with the VM before IBM cloud says it's in a stable condition.
This worked in testing on the original PR, but has been failing on master. This PR undoes the change in order to maintain some CI stability.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.