Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all amd64 integration tests on PRs #1766

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Aug 1, 2024

Description

We split the set of integration tests run on PRs due to some of them taking a long time and some flakiness. Since we did this split, the flakiness has gone down as well as the time taken to run the tests, so we might as well always run the full set.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI is enough

@Molter73 Molter73 changed the title Run all integration tests Run all amd64 integration tests on PRs Aug 1, 2024
We split the set of integration tests run on PRs due to some of them
taking a long time and some flakiness. Since we did this split, the
flakiness has gone down as well as the time taken to run the tests, so
we might as well always run the full set.
@Molter73 Molter73 marked this pull request as ready for review August 1, 2024 13:17
@Molter73 Molter73 requested a review from a team as a code owner August 1, 2024 13:17
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Molter73 Molter73 merged commit 1bbb692 into master Aug 1, 2024
87 checks passed
@Molter73 Molter73 deleted the mauro/run-all-tests branch August 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants