Run konflux builds and tests on all PRs #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help us prevent breaking this build on master.
Molter73
force-pushed
the
mauro/run-konflux-on-prs
branch
from
0c62805
to
20f3874
Compare
msugakov
approved these changes
Sep 11, 2024
| @@ -20,10 +20,85 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
There was a problem hiding this comment.
[two things, not about this line]
One:
name: Run konflux workflowsmay suggest that GitHub drives/triggers Konflux which is not the case. I'd propose to change the name along the lines of "Run post-Konflux workflows" or "Test Konflux builds" or something.
Two:
This has cron schedule, I wonder what's the use?
There was a problem hiding this comment.
One:
name: Run konflux workflows
I agree, I'll rename the workflow.
Two:
This has cron schedule, I wonder what's the use?
I believe this was added by @Stringy in order to run the konflux tests on nightlies, but I don't think it has much point if we don't trigger the konflux build as well. I'll ask him about it.
msugakov
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should help us prevent breaking this build on master.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed