Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-25565: Fail Konflux builds if required ARGs aren't provided #1847

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

msugakov
Copy link
Contributor

@msugakov msugakov commented Sep 17, 2024

Description

See related ticket.

Checklist

  • Investigated and inspected CI test results
  • [ ] Updated documentation accordingly

Automated testing

No automated testing changes.

Testing Performed

Ensuring CI is green.

@msugakov
Copy link
Contributor Author

/retest collector-build

Copy link

openshift-ci bot commented Sep 17, 2024

@msugakov: No presubmit jobs available for stackrox/collector@master

In response to this:

/retest collector-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@msugakov msugakov marked this pull request as ready for review September 18, 2024 07:36
@msugakov msugakov requested a review from a team as a code owner September 18, 2024 07:36
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would think podman/buildah would have at least a CLI argument to force this kind of thing to error, it's sad that it doesn't.

@msugakov
Copy link
Contributor Author

it's sad that it doesn't

Surprises me too.

@msugakov msugakov merged commit 7479943 into master Sep 19, 2024
122 of 158 checks passed
@msugakov msugakov deleted the misha/ROX-25565-fail-if-no-args-konflux branch September 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants