refactor if-statements for better readability #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBaeumer
changed the title
Co-authored-by: David Shrewsberry <[email protected]>
SimonBaeumer
force-pushed
the
sb/big-refactoring
branch
from
2d2c7df
to
9d184fc
Compare
erthalion
approved these changes
Sep 17, 2024
Molter73
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Not something for this PR, but we could enable the InsertBraces style check in our .clang-format file and apply it everywhere that matters
https://clang.llvm.org/docs/ClangFormatStyleOptions.html#insertbraces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added brackets to ifs.