Enable InsertBraces in clang-format

[SimonBaeumer]

Description

Enable expand brackets clang-format for better readability.

#1851

[SimonBaeumer]

Options to update clang-formater by @Molter73 in this comment: #1849 (comment)

[Molter73]

So the lint workflow is now broken because this line:

collector/.github/workflows/lint.yml

Line 21 in 3f10453

- uses: pre-commit/[email protected]

Is trying to install packages using pip on a system that has python managed by the OS (this is actually a good thing, a lot of systems have been broken by pip installing packages over the actual system ones).

Additionally, the pre-commit/action workflow is now in maintanance mode and they suggest using pre-commit-ci instead, but that looks like a tool that fixes commits and is not really what we want, we want to check PRs, we don't want to have additional commits pushed on us.

I suggest we change the pre-commit/action line for the following block instead:

      - name: Run pre-commit
        run: |
          python3 -m venv .venv
          source .venv/bin/activate
          python3 -m pip install pre-commit
          pre-commit run --all-files

Not as convenient as a prebuilt action, but it's only 4 lines of bash, so 🤷🏻‍♂️.

[SimonBaeumer]

So the lint workflow is now broken because this line:

collector/.github/workflows/lint.yml

Line 21 in 3f10453

- uses: pre-commit/[email protected]

Is trying to install packages using pip on a system that has python managed by the OS (this is actually a good thing, a lot of systems have been broken by pip installing packages over the actual system ones).

Additionally, the pre-commit/action workflow is now in maintanance mode and they suggest using pre-commit-ci instead, but that looks like a tool that fixes commits and is not really what we want, we want to check PRs, we don't want to have additional commits pushed on us.

I suggest we change the pre-commit/action line for the following block instead:

      - name: Run pre-commit
        run: |
          python3 -m venv .venv
          source .venv/bin/activate
          python3 -m pip install pre-commit
          pre-commit run --all-files

Not as convenient as a prebuilt action, but it's only 4 lines of bash, so 🤷🏻‍♂️.

Let's try it.

[Molter73]

Let's try it.

Well it sorta worked, looks like the clang-format step failed, maybe we need to rebase this PR so the changes you did to the braces are picked up? Also, could you add --show-diff-on-failure --color=always to the pre-commit command in the lint workflow? That should help see what the differences actually are.

There's also a lint error I was not expecting here:

collector/integration-tests/container/perf/scripts/init.sh

Lines 143 to 146 in 3f10453

	if [[ "$(sysctl -n kernel.kptr_restrict)" != "0" ]]; then
	# If this is not zero, it can interfere with most of the tools
	sysctl -w kernel.kptr_restrict=0
	fi

That block seems unreachable because the previous if block does exit 0 on both of its branches. @Stringy, can we remove the block or should we move it above the previous one?

[Molter73]

Discussed offline and decided I'll be taking over the PR, @SimonBaeumer sorry your small change got so out of hand 😅

[Stringy]

LGTM!

[Molter73]

Looks like konflux is gonna time out, but we don't really care about it, so I'm merging as is.