Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify collector config #12769

Draft
wants to merge 2 commits into
base: jv-poc-collector-cluster-config
Choose a base branch
from

Conversation

SimonBaeumer
Copy link
Member

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at b9822b6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-523-gb9822b6a6b.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.10%. Comparing base (b63784f) to head (b9822b6).

Additional details and impacted files
@@                         Coverage Diff                         @@
##           jv-poc-collector-cluster-config   #12769      +/-   ##
===================================================================
+ Coverage                            48.03%   48.10%   +0.07%     
===================================================================
  Files                                 2438     2434       -4     
  Lines                               175124   174484     -640     
===================================================================
- Hits                                 84125    83944     -181     
+ Misses                               84202    83762     -440     
+ Partials                              6797     6778      -19     
Flag Coverage Δ
go-unit-tests 48.10% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants