-
Notifications
You must be signed in to change notification settings - Fork 28
Core Url update #191
base: master
Are you sure you want to change the base?
Core Url update #191
Conversation
…esponse types are different even in the V1 version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase the PR. This contains the changes from the last pr as well.
What about the DID method? Do you want to adapt the new specification?
@@ -19,6 +17,8 @@ class DIDs { | |||
|
|||
if (didType == "btc-addr") { | |||
return did.split(':')[2] | |||
}else if (didType == "stx-addr") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have a proper did specification for stacks 2.0. https://github.com/jolocom/stacks.js/blob/feat/add_did_resolver_package/packages/did-resolver/docs/DID_Method_Spec.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a more generic version, and updated the validation since according to the documentation the following
did:stack:v0:15gxXgJyT5tM5A4Cbx99nwccynHYsBouzr-3
, is correct and can existe a multiple of different transactions, names, and namespaces.
No description provided.