This repository has been archived by the owner on Apr 11, 2022. It is now read-only.
Fix search bugs, various 404s, performance improvements #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Update home page stats formatting. hotfix for normalizing prometheus paths
* Several updates for changes to the API output data. * Fix floating-point errors with bitcoin value displays.
* Fixed slow and buggy search functionality.
* Moved search logic off of the client - fixed bug when js is disabled and improved search result speed.
* Fixed blocks pagination bug.
…rror details during search failures
… routing bugs causing 404s
This was referenced Jan 24, 2020
Merged
|
Tagging @aulneau to help review the front-end next.js related changes |
hstove
reviewed
Jan 29, 2020
| @@ -75,7 +75,7 @@ const ListItemComponent = sys( | |||
|
|
|||
| const Item = ({ href, as, ...rest }) => | |||
| href ? ( | |||
| <Link href={href} passHref as={as}> | |||
| <Link href={href} passHref as={as} prefetch={false}> | |||
There was a problem hiding this comment.
Good call to not prefetch too many things. FYI, if you upgrade to next.js 9 (which is a good upgrade), they automatically prefetch all links that are visible unless you explicitly say not to (as here).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR intended to fix bugs related to searching, and various instances of page loading timeouts or
Not founderrors. The primary problems were:Nearly all pages now have non-cached sub-second load times. Some take a few seconds, but less than the >1 minute / error durations. Notably, name pages and the home page consistently take a few seconds when not cached.
Note: Some pages will occasionally take ~15 seconds to load when both A) the cache expired and B) the core node ProgressDB is performing a bulk data import cycle. Additionally, some pages can show errors when one of the core node API endpoints returns internal server errors. A follow-up PR will alleviate both of these conditions.
Bug fixes
Several other bugs were fixed in the process of debugging and tackling these issues. I went through the backlog and the following issue should now be closed:
block height to datetimeestimation function. These all now use the real block times, except for blocks in the future, e.g. vesting / locktimes.Note for reviewers
Most of the changes are in the explorer API repo, see associated PR: stacks-archive/blockstack-explorer-api#32
Changes to this repo (the front-end) include:
<Link>pathname fixes.These PRs also include the changeset from the
remove blockchain.info APIfront-end and API PRs. Those could not be easily tested due to bugs in staging and next.js routing.Testing
Both the front-end and API changes are live on staging: https://explorer.staging.blockstack.xyz