Merge pull request #14 from blockstack/fix/require-leading-s

fix: require that c32 addresses start with `S`
stacks-network · Apr 16, 2021 · 5777e44 · 5777e44
2 parents 5b0e305 + 5a9d37b
commit 5777e44
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/address.ts b/src/address.ts
@@ -52,6 +52,9 @@ export function c32addressDecode(c32addr: string) : [number, string] {
   if (c32addr.length <= 5) {
     throw new Error('Invalid c32 address: invalid length')
   }
+  if (c32addr[0] != 'S') {
+    throw new Error('Invalid c32 address: must start with "S"')
+  }
   return c32checkDecode(c32addr.slice(1))
 }
 

diff --git a/tests/unitTests/src/index.ts b/tests/unitTests/src/index.ts
@@ -555,7 +555,8 @@ export function c32addressTests() {
       () => c32addressDecode('ST2J6ZY48GV1EZ5V2V5RB9MP66SW86PYKKQYAC0RQ0'),
       () => c32addressDecode('ST2J6ZY48GV1EZ5V2V5RB9MP66SW86PYKKQYAC0RR'),
       () => c32addressDecode('ST2J6ZY48GV1EZ5V2V5RB9MP66SW86PYKKQYAC0R'),
-      () => c32addressDecode('ST2J')
+      () => c32addressDecode('ST2J'),
+      () => c32addressDecode('bP2CT665Q0JB7P39TZ7BST0QYCAQSMJWBZK8QT35J')
     ]
 
     t.plan(invalids.length + invalidDecodes.length)