Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tasks #16

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Add CI tasks #16

merged 4 commits into from
Aug 15, 2023

Conversation

Acaccia
Copy link
Collaborator

@Acaccia Acaccia commented Aug 14, 2023

This PR adds some CI to the repo:

  • on each new PR against main, we run the tests, check formatting and check for the absence of clippy warnings
  • on each push to main, same checks
  • on change in Cargo.toml or Cargo.lock, we run cargo-audit
  • every day, we run cargo-audit and check for clippy warnings (in case there would be new ones after a toolchain update).

Closes #12

@Acaccia Acaccia requested a review from obycode August 14, 2023 15:06
@Acaccia Acaccia self-assigned this Aug 14, 2023
@Acaccia
Copy link
Collaborator Author

Acaccia commented Aug 14, 2023

I think this needs the merge of #15 which fixes formatting and clippy warnings.

@cylewitruk
Copy link
Member

cylewitruk commented Aug 14, 2023

I think this needs the merge of #15 which fixes formatting and clippy warnings.

Yeah if you based it on #15 then I fixed a bunch clippy stuff + fmt waiting

Just a tip that @obycode mentioned that he likes "Conventional Commits" -> https://www.conventionalcommits.org/en/v1.0.0/

@obycode
Copy link
Collaborator

obycode commented Aug 14, 2023

Just a tip that @obycode mentioned that he likes "Conventional Commits"

Yeah, it's helpful to auto-generate changelogs and to determine release versions numbers.

Copy link
Collaborator

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @Acaccia!

@obycode
Copy link
Collaborator

obycode commented Aug 14, 2023

I went ahead and enabled the check that the be required to pass before PRs can merge into main.

@Acaccia
Copy link
Collaborator Author

Acaccia commented Aug 15, 2023

Just a tip that @obycode mentioned that he likes "Conventional Commits" -> conventionalcommits.org/en/v1.0.0

I always agree with commit conventions. I sadly did not now we were following one on this repo.

This should be in the Readme or a CONTRIBUTING.md file. And in this case, we should also describe the possible types and scopes.

@obycode
Copy link
Collaborator

obycode commented Aug 15, 2023

Woohoo, these checks are working great! 🎉

@obycode obycode merged commit 69d34a4 into main Aug 15, 2023
3 of 5 checks passed
@obycode obycode deleted the ci/add_some_workflows branch August 15, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ 💻 Clarity VM ] GitHub CI
3 participants