Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOB memory access on from-consensus-buff? #591

Merged
merged 10 commits into from
Jan 7, 2025
Merged

OOB memory access on from-consensus-buff? #591

merged 10 commits into from
Jan 7, 2025

Conversation

BowTiedWoo
Copy link
Collaborator

This PR fixes an out of bounds memory access bug on from-consensus-buff?.

Fixes: #560

@BowTiedWoo BowTiedWoo requested a review from Acaccia December 18, 2024 14:11
@BowTiedWoo BowTiedWoo marked this pull request as ready for review December 18, 2024 17:15
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (41079f3) to head (2cef72a).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   85.48%   85.51%   +0.02%     
==========================================
  Files          46       46              
  Lines       24266    24324      +58     
  Branches    24266    24324      +58     
==========================================
+ Hits        20745    20800      +55     
- Misses       1672     1674       +2     
- Partials     1849     1850       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Acaccia
Acaccia requested changes Dec 19, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
clar2wasm/src/deserialize.rs Outdated Show resolved Hide resolved
clar2wasm/src/deserialize.rs Outdated Show resolved Hide resolved
clar2wasm/src/deserialize.rs Show resolved Hide resolved
@BowTiedWoo
chore: rename result_offset accordingly
30eadb9 
+ modify comment for `deserialize_from_memory`
@BowTiedWoo BowTiedWoo requested a review from Acaccia December 20, 2024 12:27
Acaccia
Acaccia requested changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some nitpicking...

clar2wasm/src/deserialize.rs Outdated Show resolved Hide resolved
clar2wasm/src/words/consensus_buff.rs Outdated Show resolved Hide resolved
@BowTiedWoo BowTiedWoo requested a review from Acaccia January 3, 2025 14:40
Acaccia
Acaccia previously approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. We just need a rewriting of the new created issue, as mentioned in the discussion.

@Acaccia Acaccia dismissed their stale review January 6, 2025 10:06

I missed the change in Cargo.lock

Acaccia
Acaccia requested changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to revert the change in Cargo.lock. It is not the responsibility of this PR to update the clarity dependency.

@BowTiedWoo BowTiedWoo added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 22d35e4 Jan 7, 2025
16 checks passed
@BowTiedWoo BowTiedWoo deleted the fix/from-consensus-buff-memory-oob branch January 7, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acaccia Acaccia Acaccia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Out of bounds memory access from from-consensus-buff?
2 participants
@BowTiedWoo @Acaccia