Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce strict mode for Romeo #297

Closed
1 task
stjepangolemac opened this issue Oct 17, 2023 · 1 comment · Fixed by #309
Closed
1 task

Introduce strict mode for Romeo #297

stjepangolemac opened this issue Oct 17, 2023 · 1 comment · Fixed by #309
Assignees
Labels
enhancement New feature or request

Comments

@stjepangolemac
Copy link
Contributor

Description

At the moment due to unexpected events that relate to external services Romeo relies upon it's possible to crash in such a state that replaying crashes it.

Context

When we started working on Romeo we decided that we'll crash for every unexpected events, or in this case transaction status updates. That made it easier to uncover and fix bugs but it also ultimately crashes Romeo when it can just ignore such events.

If we introduce something like a "strict mode" and disable it most of the time we can increase reliability of Romeo. When debugging an issue a strict mode can help us crash in a more meaningful way with an useful message.

Expected Approach

  1. Introduce strict mode as a configuration option
  2. When enabled don't crash but just log unexpected occurences

Acceptance Criteria

  • Romeo doesn't crash on unknown transaction updates
@stjepangolemac stjepangolemac added the enhancement New feature or request label Oct 17, 2023
@stjepangolemac
Copy link
Contributor Author

cc @friedger @AshtonStephens

@stjepangolemac stjepangolemac linked a pull request Oct 20, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants