Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strict mode turned off by default #309

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

stjepangolemac
Copy link
Contributor

@stjepangolemac stjepangolemac commented Oct 20, 2023

Allow romeo to not crash when not absolutely necessary.

Summary of Changes

  • Introduced strict mode
  • Disabled it by default

How were these changes tested?

I've manually tested these changes in local devnet and everything looks correct.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@stjepangolemac stjepangolemac self-assigned this Oct 20, 2023
@stjepangolemac stjepangolemac linked an issue Oct 20, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #309 (1c6819a) into main (eac5a87) will decrease coverage by 0.08%.
Report is 2 commits behind head on main.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   43.12%   43.04%   -0.08%     
==========================================
  Files          45       45              
  Lines        5359     5371      +12     
  Branches       47       47              
==========================================
+ Hits         2311     2312       +1     
- Misses       3047     3058      +11     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
romeo/src/bitcoin_client.rs 36.36% <100.00%> (+0.32%) ⬆️
romeo/src/config.rs 8.00% <0.00%> (-0.17%) ⬇️
romeo/src/state.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friedger friedger closed this Oct 20, 2023
@friedger friedger reopened this Oct 20, 2023
@friedger friedger merged commit f692795 into main Oct 20, 2023
8 of 9 checks passed
@friedger friedger deleted the 297-introduce-strict-mode-for-romeo branch October 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Introduce strict mode for Romeo
3 participants