-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sBTC DR] Remove tree depth from burn and mint #240
Conversation
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 38.76% 38.39% -0.38%
==========================================
Files 45 45
Lines 5167 5134 -33
Branches 47 47
==========================================
- Hits 2003 1971 -32
+ Misses 3163 3162 -1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary of Changes
The parameter
tree-depth
is always the length of the proof minus 1 when callingwas-tx-mined
. This PR removes this parameter and uses the proof length instead.This fixes #239.
Testing
Risks
This changes the public API of the contract and requires to update all clients, including the web bridge.
How were these changes tested?
Running
./scripts/tests.sh
andcargo test
What future testing should occur?
Integration testing as in #215 and web integration testing.
Checklist: