-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TryFrom<String> for PrincipalData #300
Conversation
While there is a risk to loose sbtc by sending to a contract, this possibility might inspire developers at the hackathon. |
Codecov Report
@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 43.12% 43.71% +0.59%
==========================================
Files 45 45
Lines 5359 5433 +74
Branches 47 47
==========================================
+ Hits 2311 2375 +64
- Misses 3047 3057 +10
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but let's make it a bit more idiomatic and then merge.
Co-authored-by: Carlos Alejandro Gutierrez Sandoval <[email protected]>
25f1447
Summary of Changes
This PR implements conversion from string to principal data that is used by the sbtc cli to enable deposits to stacks contracts.
Fixes #299
Testing
Risks
This enables users to deposit sbtc to a contract without any checks whether the contract exists or can handle recieved sbtc tokens.
How were these changes tested?
What future testing should occur?
Integration test
Checklist: