-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration ci #303
base: main
Are you sure you want to change the base?
Integration ci #303
Conversation
4c96705
to
aca6b7b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 41.49% 43.09% +1.60%
==========================================
Files 40 45 +5
Lines 5111 5362 +251
Branches 0 47 +47
==========================================
+ Hits 2121 2311 +190
- Misses 2990 3050 +60
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aca6b7b
to
2cd98d7
Compare
What's going on with this PR? |
@AshtonStephens I added a brief description. |
blocked by #350 |
Summary of Changes
Follow up PR #215 to add a CI job running integration tests—blocked atm and not actively working on it.
I would appreciate feedback on #307 and #215 first.
Devenv's javascript services are too big and are making 'devenv' CI fail. I can't fix it myself right now without digging deeper. I've thought about options: merging javascript containers, increasing runner's resources, having a dedicated devenv profile to skip building unnecessary services, and last but not least, minimizing image size by having a 'release build' for javascript-based services (My first attempt failed).
This PR exports docker image artifacts from the 'devenv build' job. Blocked by 1.
Split devenv into different node profiles. #307 may help with 1. With devenv profiles, I can have a profile with the minimal services needed for testing.
Testing
Risks
How were these changes tested?
What future testing should occur?
Checklist: