Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More features for strict mode #327

Merged
merged 4 commits into from
Oct 27, 2023
Merged

More features for strict mode #327

merged 4 commits into from
Oct 27, 2023

Conversation

friedger
Copy link
Collaborator

Summary of Changes

This PR adds more features to strict mode that means that non-strict mode won't fail

  • when bitcoin client saw a transport error
  • when a bitcoin tx failed
  • when a stx tx update results in an unexpected state
  • when mint or burn stx tx couldn't be broadcasted

Testing

Risks

Users of Romeo DR don't see when deposit or withdraw requests fail

How were these changes tested?

Running romeo on testnet for 12h

What future testing should occur?

Unit tests for the state machine

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #327 (13dc576) into main (f3606db) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   43.71%   43.44%   -0.28%     
==========================================
  Files          45       45              
  Lines        5433     5467      +34     
  Branches       47       47              
==========================================
  Hits         2375     2375              
- Misses       3057     3091      +34     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
romeo/src/bitcoin_client.rs 36.18% <0.00%> (-0.19%) ⬇️
romeo/src/system.rs 0.00% <0.00%> (ø)
romeo/src/state.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@radicleart radicleart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

romeo/src/state.rs Show resolved Hide resolved
romeo/src/state.rs Show resolved Hide resolved
romeo/src/state.rs Show resolved Hide resolved
romeo/src/state.rs Show resolved Hide resolved
romeo/src/state.rs Show resolved Hide resolved
romeo/src/system.rs Show resolved Hide resolved
romeo/src/system.rs Show resolved Hide resolved
@friedger
Copy link
Collaborator Author

@CAGS295 Appreciate your comments. Will merge now and see whether we can refactor at some time.

@friedger friedger merged commit 6470223 into main Oct 27, 2023
7 of 8 checks passed
@friedger friedger deleted the 262-more-strict-panics branch October 27, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants