-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More features for strict mode #327
Conversation
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 43.71% 43.44% -0.28%
==========================================
Files 45 45
Lines 5433 5467 +34
Branches 47 47
==========================================
Hits 2375 2375
- Misses 3057 3091 +34
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
@CAGS295 Appreciate your comments. Will merge now and see whether we can refactor at some time. |
Summary of Changes
This PR adds more features to strict mode that means that non-strict mode won't fail
Testing
Risks
Users of Romeo DR don't see when deposit or withdraw requests fail
How were these changes tested?
Running romeo on testnet for 12h
What future testing should occur?
Unit tests for the state machine
Checklist: