Skip to content

feat: implement dry-run mode for signer #319

feat: implement dry-run mode for signer

feat: implement dry-run mode for signer #319

Triggered via pull request January 10, 2025 20:05
Status Failure
Total duration 47s
Artifacts

clippy.yml

on: pull_request
Clippy Check
39s
Clippy Check
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 1 warning
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L136
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:136:26 | 136 | write_next(fd, &(self.as_bytes().len() as u8))?; | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L133
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:133:17 | 133 | self.as_bytes().len() | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L129
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:129:16 | 129 | || self.as_bytes().len() > CONTRACT_MAX_NAME_LENGTH | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L128
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:128:12 | 128 | if self.as_bytes().len() < CONTRACT_MIN_NAME_LENGTH | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L95
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:95:26 | 95 | write_next(fd, &(self.as_bytes().len() as u8))?; | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L90
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:90:12 | 90 | if self.as_bytes().len() > MAX_STRING_LEN as usize { | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes = note: `-D clippy::needless-as-bytes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_as_bytes)]`
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L136
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:136:26 | 136 | write_next(fd, &(self.as_bytes().len() as u8))?; | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L133
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:133:17 | 133 | self.as_bytes().len() | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L129
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:129:16 | 129 | || self.as_bytes().len() > CONTRACT_MAX_NAME_LENGTH | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L128
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:128:12 | 128 | if self.as_bytes().len() < CONTRACT_MIN_NAME_LENGTH | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L95
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:95:26 | 95 | write_next(fd, &(self.as_bytes().len() as u8))?; | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes
needless call to `as_bytes()`: clarity/src/vm/representations.rs#L90
error: needless call to `as_bytes()` --> clarity/src/vm/representations.rs:90:12 | 90 | if self.as_bytes().len() > MAX_STRING_LEN as usize { | ^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `self.len()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes = note: `-D clippy::needless-as-bytes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_as_bytes)]`
Clippy Check
Clippy had exited with the 101 exit code
Clippy Check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636