-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include txid in more failure logs #4396
Open
janniks
wants to merge
14
commits into
develop
Choose a base branch
from
Add-txid-to-post-condition-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
94b5ce8
fix: include txid in failure logs
janniks f78c8d7
Merge branch 'develop' into Add-txid-to-post-condition-check
janniks e91e645
Merge branch 'develop' into Add-txid-to-post-condition-check
janniks 3fff50b
Merge branch 'develop' into Add-txid-to-post-condition-check
jcnelson 863490a
Merge branch 'develop' into Add-txid-to-post-condition-check
janniks 5f1173a
test: ensure auto-generated test contract names are not too long
janniks 86dd3df
test: remove leading dashes from auto-generated test contract names
janniks 86eea3f
test: trim leading non-alpha from test name
janniks 487ebbe
Merge branch 'develop' into Add-txid-to-post-condition-check
janniks 464b319
chore: address pr review comments
janniks f947ea0
fix: remove duplicate txid log
janniks 4b32eb2
Merge branch 'develop' into Add-txid-to-post-condition-check
janniks ed415b9
fix: remove duplicate txid log
janniks e37f5e0
fix: move non-alpha trim as last step
janniks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this string is too long. Try 32 chars:
"12321212321212321212321212321212"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even simpler,
Txid([0;32])
.