-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename helium to local testnet/regtest #4911
Open
ldiego08
wants to merge
4
commits into
stacks-network:develop
Choose a base branch
from
ldiego08:chore/rename-helium-to-local-testnet
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
23604a2
chore: deprecate helium subcommand and use regtest internally
ldiego08 424b13b
chore: rename helium to local testnet
ldiego08 819d0ea
Merge branch 'develop' into chore/rename-helium-to-local-testnet
ldiego08 925ac5b
Merge branch 'develop' into chore/rename-helium-to-local-testnet
ldiego08 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8687,14 +8687,14 @@ pub mod test { | |
epoch_id: StacksEpochId::Epoch2_05, | ||
start_height: 1, | ||
end_height: 2, | ||
block_limit: HELIUM_BLOCK_LIMIT_20.clone(), | ||
block_limit: LOCAL_TESTNET_BLOCK_LIMIT_20.clone(), | ||
network_epoch: PEER_VERSION_EPOCH_2_05, | ||
}, | ||
_ => StacksEpoch { | ||
epoch_id: StacksEpochId::Epoch21, | ||
start_height: 2, | ||
end_height: u64::MAX, | ||
block_limit: HELIUM_BLOCK_LIMIT_20.clone(), | ||
block_limit: LOCAL_TESTNET_BLOCK_LIMIT_20.clone(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as in the above comment. And for the others as well. |
||
network_epoch: PEER_VERSION_EPOCH_2_1, | ||
}, | ||
}) | ||
|
@@ -8708,7 +8708,7 @@ pub mod test { | |
epoch_id: StacksEpochId::Epoch10, | ||
start_height: 0, | ||
end_height: 0, | ||
block_limit: HELIUM_BLOCK_LIMIT_20.clone(), | ||
block_limit: LOCAL_TESTNET_BLOCK_LIMIT_20.clone(), | ||
network_epoch: PEER_VERSION_EPOCH_2_0, | ||
}), | ||
StacksEpochId::Epoch20 => self.get_stacks_epoch(0), | ||
|
@@ -8916,7 +8916,7 @@ pub mod test { | |
epoch_id: StacksEpochId::Epoch21, | ||
start_height: 0, | ||
end_height: u64::MAX, | ||
block_limit: HELIUM_BLOCK_LIMIT_20.clone(), | ||
block_limit: LOCAL_TESTNET_BLOCK_LIMIT_20.clone(), | ||
network_epoch: PEER_VERSION_EPOCH_2_1, | ||
}) | ||
} | ||
|
@@ -8929,7 +8929,7 @@ pub mod test { | |
epoch_id: StacksEpochId::Epoch10, | ||
start_height: 0, | ||
end_height: 0, | ||
block_limit: HELIUM_BLOCK_LIMIT_20.clone(), | ||
block_limit: LOCAL_TESTNET_BLOCK_LIMIT_20.clone(), | ||
network_epoch: PEER_VERSION_EPOCH_2_0, | ||
}), | ||
_ => self.get_stacks_epoch(0), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a more explicit naming as it adds extra terms, while its goal is of removing them.
eg. REGTEST_BLOCK_LIMIT or REGTEST_OR_MOCKNET_BLOCK_LIMIT.
I am open to any suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ASuciuX regtest and mocknet refer to local testnet nodes, hence why I suggested reconciling to "local" whenever "helium" was being used interchangeably for both. Past the CLI and into the runloops, regtest and mocknet are used for the respective Bitcoin burnchains. Reconciling might help create that boundary between the Stacks node and its burnchains. With that said, I'm okay with renaming to
REGTEST_OR_MOCKNET_BLOCK_LIMIT
. I don't think there will be other chains that would complicate this convention (e.g.REGTEST_OR_MOCKNET_OR_SIMNET_BLOCK_LIMIT
). Thoughts?