Fix multiple_miners* tests #5237
Merged
+154
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks for multiple_miners* tests Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
changed the title
…i node tests Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/fix-multiple-miners
…-network/stacks-core into chore/fix-multiple-miners
jferrant
changed the title
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
chore/fix-multiple-miners
branch
from
371de4e
to
1f53fac
Compare
… into chore/fix-multiple-miners
…ch 3 and shutdown the runloop Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/fix-multiple-miners
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/fix-multiple-miners
|
Unfortunately it looks like |
NEIN! haha taking another wack at it. |
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/fix-multiple-miners
Signed-off-by: Jacinta Ferrant <[email protected]>
…tly one microblocks Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/fix-multiple-miners
kantai
previously approved these changes
Oct 1, 2024
|
This LGTM -- my only comment is that you should use the approach from 6a3746c in the rejection tracking. |
Signed-off-by: Jacinta Ferrant <[email protected]>
…globally processed block Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
Oct 1, 2024
… into chore/fix-multiple-miners
|
This fixes |
This is not used in signer v0. Fixes `tests::nakamoto_integrations::continue_tenure_extend`
kantai
previously approved these changes
Oct 2, 2024
…g for anchor blocks to arrive Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
approved these changes
Oct 2, 2024
obycode
approved these changes
Oct 2, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both multiple_miners and multiple_miners_with_nakamoto_blocks tests.