Fix typos in codebase #5349
Open
Fix typos in codebase #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
obycode
requested changes
Oct 21, 2024
| @@ -977,7 +977,7 @@ impl SpvClient { | |||
|
|
|||
| // contiguous? | |||
| if block_headers[0].header.prev_blockhash != parent_header.header.bitcoin_hash() { | |||
| warn!("Received discontiguous headers at height {}: we have parent {:?} ({}), but were given {:?} ({})", | |||
| warn!("Received discontinuous headers at height {}: we have parent {:?} ({}), but were given {:?} ({})", | |||
There was a problem hiding this comment.
I think "discontiguous" is correct here.
| @@ -3045,7 +3045,7 @@ impl StacksChainState { | |||
| } | |||
|
|
|||
| if signed_microblocks[0].header.sequence != 0 { | |||
| // discontiguous -- must start with seq 0 | |||
| // discontinuous -- must start with seq 0 | |||
There was a problem hiding this comment.
All uses of "discontiguous" in this file are correct.
| @@ -115,7 +115,7 @@ impl StacksChainState { | |||
| affirmation_weight: u64, | |||
| ) -> Result<(), Error> { | |||
| let StacksBlockHeaderTypes::Epoch2(header) = &tip_info.anchored_header else { | |||
| return Err(Error::InvalidChildOfNakomotoBlock); | |||
| return Err(Error::InvalidChildOfNakamotoBlock); | |||
There was a problem hiding this comment.
See my comment in stackslib/src/chainstate/stacks/mod.rs.
| @@ -126,7 +126,7 @@ pub enum Error { | |||
| MinerAborted, | |||
| ChannelClosed(String), | |||
| /// This error indicates a Epoch2 block attempted to build off of a Nakamoto block. | |||
| InvalidChildOfNakomotoBlock, | |||
| InvalidChildOfNakamotoBlock, | |||
There was a problem hiding this comment.
I'm not sure if it's safe to change this or if it will be consensus-breaking. I'll need to come back to this.
|
Please resolve merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
Note: All changes are focused on comments, variable names, and documentation where the typos were present.
Related Issue