Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/shadow block tooling #5362

Open
wants to merge 18 commits into
base: fix/5285
Choose a base branch
from
Open

Conversation

jcnelson
Copy link
Member

This adds tooling to stacks-inspect to generate and insert shadow blocks into a production chainstate.

It'll probably get more commits as we test it out, but it's opened here for review so we can start making images off of it and testing it out on Nakamoto testnet.

@jcnelson jcnelson requested a review from a team as a code owner October 23, 2024 02:58
@jcnelson jcnelson changed the base branch from develop to fix/5285 October 23, 2024 02:59
@@ -1166,6 +1191,162 @@ simulating a miner.
println!("{:?}", inv);
}

if argv[1] == "get-nakamoto-tip" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these code blocks into another module, like src/shadow_blocks.rs or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I can add unit tests that way as well.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

stackslib/src/main.rs Outdated Show resolved Hide resolved
@jcnelson jcnelson requested a review from a team as a code owner October 24, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants