Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miner_recovers_when_broadcast_block_delay_across_tenures_occurs: Do not expect an exact number of signatures #5380

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix miner_recovers_when_broadcast_block_delay_across_tenures_occurs: Do not expect an exact number of signatures #5380

merged 1 commit into from
Oct 24, 2024
+63 −93

Conversation

jferrant
Copy link
Collaborator

Closes #5379

Also cleaned up the loops cause why not?

@jferrant jferrant requested a review from a team as a code owner October 24, 2024 19:03
obycode
obycode approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jferrant jferrant added this pull request to the merge queue Oct 24, 2024
Merged via the queue into develop with commit f759c95 Oct 24, 2024
138 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcnelson jcnelson jcnelson approved these changes

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

@hstove hstove Awaiting requested review from hstove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jferrant @jcnelson @kantai @obycode