-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update peer host to parse dns instead of ip #5533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
previously approved these changes
Dec 11, 2024
wileyj
previously approved these changes
Dec 17, 2024
ahh just notifed this @ASuciuX but there is a merge conflict that needs to be resolved. |
Thank you @wileyj. The file was moved from stacks-node to stackslib, I've updated it. |
wileyj
approved these changes
Dec 18, 2024
jcnelson
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Dec 20, 2024
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the flow of the self.connect() function you can see that it is trying to open a
TCP
connection with net::TcpStream::connect((self.config.peer_host.as_str(), self.config.peer_port). If the peer_host is aDNS
, it automatically tries to connect to theIPs
paired to theDNS
.The error was occurring because the
DNS
was converted directly intoipv4
address at the moment of reading the data from the config file. Afterwards, it didn’t have theDNS
linked as it was only keeping theipv4
address.I've run the integration test suite and all of them passed. Please let me know if there is anything else I could run to check this.
So the solution applied here is to keep the
DNS
instead of converting it toipv4
and it will automatically reconnect successfully.