Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarity and libsigner to clippy CI and fix all clippy warnings #5592

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Add clarity and libsigner to clippy CI and fix all clippy warnings #5592

merged 8 commits into from
Dec 20, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Dec 18, 2024 •
edited
Loading

No description provided.

@jferrant jferrant requested review from a team as code owners December 18, 2024 18:08
hstove
hstove previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Man, some of the stuff clippy can do is pretty amazing

clarity/src/vm/analysis/read_only_checker/mod.rs Show resolved Hide resolved
@jferrant
Fix failed equality change
c234c27 
Signed-off-by: Jacinta Ferrant <[email protected]>
jbencin
jbencin reviewed Dec 18, 2024
View reviewed changes
clarity/src/vm/contexts.rs Outdated Show resolved Hide resolved
jbencin
jbencin reviewed Dec 18, 2024
View reviewed changes
clarity/src/vm/contexts.rs Outdated Show resolved Hide resolved
@jferrant jferrant requested review from hstove and jbencin December 18, 2024 19:36
jbencin
jbencin reviewed Dec 18, 2024
View reviewed changes
clarity/src/vm/contexts.rs Outdated Show resolved Hide resolved
jbencin
jbencin reviewed Dec 18, 2024
View reviewed changes
clarity/src/vm/docs/mod.rs Outdated Show resolved Hide resolved
jbencin
jbencin reviewed Dec 18, 2024
View reviewed changes
clarity/src/vm/mod.rs Outdated Show resolved Hide resolved
jbencin
jbencin previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lots of little improvements here. I left some suggestions and personally I don't think ClarityName::from() on a constant value is a problem, but others might take issue with it

@jferrant jferrant requested review from jbencin and jcnelson December 18, 2024 23:01
@jferrant jferrant changed the title Add clarity to clippy CI and fix all clippy warnings Add clarity and libsigner to clippy CI and fix all clippy warnings Dec 19, 2024
@jferrant jferrant requested a review from a team as a code owner December 19, 2024 00:18
jbencin
jbencin approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, but approved again

clarity/src/vm/types/signatures.rs Show resolved Hide resolved
jcnelson
jcnelson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done!

We do this as part of our release process already, but I just want to overcommunicate that we will want to do a chain replay before releasing this. There has been a case in the past where a Clippy PR had accidentally introduced a consensus bug (it turned out that git itself didn't merge it correctly, but the code still compiled).

@jbencin jbencin added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2024
@jferrant jferrant added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2024
@jferrant
Copy link
Collaborator Author

Looking into why CI passes but then when attempt to merge...stacks core unit tests are failing. Checked out develop and the following three tests are failing there:

failures:
    event_dispatcher::test::test_process_pending_payloads
    event_dispatcher::test::test_send_payload_timeout
    event_dispatcher::test::test_send_payload_with_db

@jferrant jferrant enabled auto-merge December 20, 2024 16:52
@jferrant jferrant added this pull request to the merge queue Dec 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 20, 2024
@jferrant jferrant added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 0ee5d7c Dec 20, 2024
2 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbencin jbencin jbencin approved these changes

@hstove hstove hstove approved these changes

@jcnelson jcnelson jcnelson approved these changes

@obycode obycode Awaiting requested review from obycode

@wileyj wileyj Awaiting requested review from wileyj

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jferrant @blockstack-devops @jcnelson @hstove @jbencin