Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/naka unlock events #5597

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Fix/naka unlock events #5597

merged 10 commits into from
Dec 20, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Dec 19, 2024 •
edited
Loading

Re-opening #5460

Closes #5455

When a block has unlock events, but the block doesn't have a coinbase TX, a "phantom" transaction will be included in the transaction receipts emitted to the event dispatcher. This doesn't (shouldn't) effect the node's chainstate, so no hard fork is required.

The "phantom" transaction mimicks the transaction used in the genesis block to allocate STX to accounts.

I've tweaked the phantom tx generation code so that they have unique txids.

@zone117x zone117x requested review from a team as code owners December 19, 2024 19:34
@wileyj wileyj added this to the 3.1.0.0.3 milestone Dec 19, 2024
@wileyj wileyj added enhancement Iterations on existing features or infrastructure. testing labels Dec 19, 2024
hstove
hstove previously approved these changes Dec 19, 2024
View reviewed changes
@hstove hstove requested a review from jcnelson December 19, 2024 23:39
obycode
obycode approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zone117x zone117x enabled auto-merge December 20, 2024 14:44
@zone117x
Copy link
Member Author

One of the required tests is failing, and I don't think it's related to this PR:

stackslib cli::test::test_drain_common_opts
thread 'cli::test::test_drain_common_opts' panicked at stackslib/src/cli.rs:108:21:
Failed to convert config file into node config: Invalid burnchain.peer_host: failed to lookup address information: Name or service not known

@obycode
Copy link
Contributor

obycode commented Dec 20, 2024

yeah, it's unrelated. Caused by a DNS lookup that started failing yesterday. See #5604.

@zone117x zone117x added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit 5f64d2d Dec 20, 2024
3 checks passed
@obycode obycode deleted the fix/naka-unlock-events branch December 20, 2024 18:45
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@hstove hstove hstove approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

Assignees
No one assigned
Labels
enhancement Iterations on existing features or infrastructure. locked testing
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@zone117x @obycode @blockstack-devops @jcnelson @hstove @wileyj