Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collapsible_else_if clippy warnings in stackslib #5630

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Fix collapsible_else_if clippy warnings in stackslib #5630

wants to merge 11 commits into from
+793 −905

Conversation

jferrant
Copy link
Collaborator

No description provided.

@jferrant jferrant requested a review from a team as a code owner December 31, 2024 20:34
@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
f8fb412 
… into fix/clippy-ci-stacks-lib-collapsible-else-if
@obycode obycode mentioned this pull request Jan 2, 2025
Open
obycode
obycode reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a couple minor comments and agree with Jeff's suggestion to fix the error.

@jferrant jferrant requested review from jbencin and obycode January 2, 2025 22:42
jcnelson
jcnelson reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one refactoring before approving. Thanks! 🙏

@jferrant
CRC: cleanup is_supported_in_epoch into by TransactionAuth and by Tra…
96de191 
…nsactionSpendingCondition

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant
Copy link
Collaborator Author

jferrant commented Jan 3, 2025

Just one refactoring before approving. Thanks! 🙏

Done! :D

@jferrant jferrant requested a review from jcnelson January 3, 2025 17:12
obycode
obycode previously approved these changes Jan 3, 2025
View reviewed changes
jbencin
jbencin previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with is_supported_in_epoch() now

@jferrant
Merge branch 'develop' of https://github.com/stacks-network/stacks-core…
69bbafb 
… into fix/clippy-ci-stacks-lib-collapsible-else-if
@jferrant jferrant dismissed stale reviews from jbencin and obycode via 69bbafb January 4, 2025 01:41
@jferrant jferrant requested review from jbencin and obycode January 4, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbencin jbencin jbencin approved these changes

@obycode obycode obycode approved these changes

@hstove hstove Awaiting requested review from hstove

@jcnelson jcnelson Awaiting requested review from jcnelson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jferrant @jcnelson @obycode @jbencin