feat: setup typescript compilation and migrate lookup file #84
+391
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirtovskis
approved these changes
Apr 12, 2022
|
Hey there any update? |
5 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is the first one in the codebase migration from Flow to typescript. Right now babel is in charge of compiling both flow and typescript files but in the long term, we will remove babel and just use the typescript compiler to match the other stacks projects config.
In this pull request I just added the necessary config to allow babel to compile both Flow and Ts files. I also converted the lookup.js file to typescript, mostly changed the types and added 2 ts-ignore to silence 2 errors and not change the current code.
If you like the way this pr is doing things, we can start migrating more files to typescript.
This change is part of the M1 stacksgov/grants-program#282.
This pull request is a cleanup of #82 made by @Akirtovskis to fix the CI issues he faced.
Checklist
npm run testpasses