-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish reframed Annotations on Current Step #261
Conversation
android/core/src/main/java/com/stadiamaps/ferrostar/core/extensions/TripStateExtensions.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a first pass over it. Honestly I think this is fine methodology-wise. We can debug the indexing issues tomorrow, but I think the approach is probably fine so you can proceed with refinements and clean-up.
android/core/src/main/java/com/stadiamaps/ferrostar/core/NavigationViewModel.kt
Outdated
Show resolved
Hide resolved
android/core/src/main/java/com/stadiamaps/ferrostar/core/models/AnnotationValue.kt
Outdated
Show resolved
Hide resolved
android/core/src/main/java/com/stadiamaps/ferrostar/core/models/AnnotationValue.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments... We're really close on this :D
apple/Tests/FerrostarCoreTests/__Snapshots__/ValhallaCoreTests/testValhallaRouteParsing.1.txt
Show resolved
Hide resolved
…rostar into feat/common/current-attrs
Closes #89
Two follow up tickets are: