-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Annotation parsing #287
Conversation
FYI @Patrick-Kladek @engali94. I know that you had a PR that I think is semi-blocked on this (#293). Feedback welcome. |
@ianthetechie I believe the new implementation by @Archdoog is more flexible and serve the purpose well. |
Sounds good, @engali94! Thanks for the review! Re: Android, we don't have a PR yet, but I think you're more than welcome to tackle it. I think that the closest thing to this which we have to @Archdoog anything you want to add before the HudHud team takes a crack at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is really close now!
One thing besides the comments is that I'm not seeing any guide changes. I think we should add documentation of how the custom annotation deserialization works (on iOS, with a stub for Android).
We should also document how to configure the speed limit display.
apple/Sources/FerrostarCore/Annotations/Models/ValhallaOSRMAnnotation.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarCore/Annotations/Models/ValhallaOSRMAnnotation.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarCore/Annotations/Models/ValhallaOSRMAnnotation.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarCore/Annotations/Models/ValhallaOSRMAnnotation.swift
Outdated
Show resolved
Hide resolved
apple/Sources/FerrostarMapLibreUI/Views/DynamicallyOrientingNavigationView.swift
Outdated
Show resolved
Hide resolved
apple/Tests/FerrostarCoreTests/Annotations/ValhallaOSRMAnnotationTests.swift
Outdated
Show resolved
Hide resolved
apple/Tests/FerrostarCoreTests/Annotations/ValhallaOSRMAnnotationTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Ian Wagner <[email protected]>
…e/annotation-parsing
I'll write up the Android ticket(s) and follow up iOS ticket for traffic congestion ticket once we merge this so I can link and reference to things. |
MaxSpeed
and associated types from common (no longer needed - we're just passing a JSON blob through to the platform code).AnnotationPublishing
andAnnotationPublisher
for piping navigation state into parsed typed annotation publishers.@Published var speedLimit
#271 for iOS