Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS S3 #44

Merged
merged 19 commits into from
Sep 20, 2024
Merged

Add AWS S3 #44

merged 19 commits into from
Sep 20, 2024

Conversation

lseelenbinder
Copy link
Member

The rust-s3 crate has a few issues, specifically a credentials refresh that is:

  1. Unconditional (even if credentials are static)
  2. Uses a ReadWrite lock that fails disturbingly often in production, causing unrecoverable errors.

This adds a backend based on the official AWS SDK, so people can choose that if they wish.

@lseelenbinder lseelenbinder marked this pull request as ready for review September 18, 2024 12:12
nyurik
nyurik approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, but looks good otherwise. All nits are up to you

.github/workflows/test.yml Outdated Show resolved Hide resolved
justfile Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@lseelenbinder lseelenbinder merged commit 87c30f1 into main Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lseelenbinder @nyurik