Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix map override #287

Merged
merged 1 commit into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
# @see Decidim::Map::DynamicMap::Builder#javascript_snippets
def javascript_snippets
[
template.javascript_pack_tag("decidim/swisstopo")
template.javascript_pack_tag("decidim/swisstopo", defer: false)

Check failure on line 20 in app/providers/decidim/map/provider/dynamic_map/swisstopo.rb

View workflow job for this annotation

GitHub Actions / lint

[Rubocop] reported by reviewdog 🐶 [Correctable] Layout/FirstArrayElementIndentation: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is. Raw Output: app/providers/decidim/map/provider/dynamic_map/swisstopo.rb:20:19: C: [Correctable] Layout/FirstArrayElementIndentation: Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is. template.javascript_pack_tag("decidim/swisstopo", defer: false) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check failure on line 20 in app/providers/decidim/map/provider/dynamic_map/swisstopo.rb

View workflow job for this annotation

GitHub Actions / lint

[Rubocop] reported by reviewdog 🐶 [Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. Raw Output: app/providers/decidim/map/provider/dynamic_map/swisstopo.rb:20:48: C: [Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. template.javascript_pack_tag("decidim/swisstopo", defer: false) ^^^^^^^^^^^^^^^^^^^
].join
end
end
Expand Down
2 changes: 0 additions & 2 deletions app/views/decidim/shared/_static_map.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
<h5>${title}</h5>
</div>
</template>
<%= stylesheet_link_tag "decidim/map" %>
<%= javascript_include_tag "decidim/map" %>
<% end %>
<% end %>
</div>
Expand Down
Loading