Upgrade/gatsby 5

[Woozl]

Nothing seems to have blown up! 🤞 I only upgraded the gatsby-plugin packages, react, and styled-components (it was throwing an error otherwise). I took a look over as much as I could so see if anything broke, but definitely the more eyes the better.

[mbwatson]

thanks for starting this, @Woozl !

when clean start fresh with an npm install i get some errors:

$  gatsby clean
info Deleting .cache, public, /home/matt/dev/renci/biodatacatalyst/website/node_modules/.cache/babel-loader,
/home/matt/dev/renci/biodatacatalyst/website/node_modules/.cache/terser-webpack-plugin
info Successfully deleted directories

$ nvm use 16.13.2
Now using node v16.13.2 (npm v8.1.2)

$ npm i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@gatsbyjs/[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.0.0', parcel: '2.x' },
npm WARN EBADENGINE   current: { node: 'v16.13.2', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.13.2', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.0.0' },

# etc

do i need to bump my Node version for running this maybe?

[Woozl]

@mbwatson yes, the minimum supported Node version is now v18

[mbwatson]

thanks, that did it. i do have to use the --legacy-peer-deps flag. is that your experience, too?

nothing exploded! 😅 but there is at least some cleanup around all those ESLint warnings about PascalCasing component names and naming a bunch of anonymous arrow functions, but all looks good at first glance.

i will be able to do more thorough testing later today or tomorrow. hopefully other reviewers can weigh in on their experience, too.

[Woozl]

oops saw your comment after I sent this, glad you figured it out

@mbwatson oh another thing to note for the fresh install if you're getting peer dependency errors is to use the --legacy-peer-deps flag when installing modules.

npm i --legacy-peer-deps

Looks like this module: @mwatson/[email protected], has a peerDep for react 16.8:

This may work to fix that

"peerDependencies": {
-  "react": "^16.8.0",
-  "react-dom": "^16.8.0"
+  "react": ">=16.8.0",
+  "react-dom": ">=16.8.0"
},

I think it's fine to use the flag, just annoying

[mbwatson]

thanks!

i don't think we're actually using my accessible accordion anymore 😢, so that dependency could safely go away