fix: allow disabling custom service accounts

Signed-off-by: GitHub <[email protected]>
stakater · Nov 15, 2024 · 404acc5 · 404acc5
1 parent 2c97270
commit 404acc5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/application/templates/cronjob.yaml b/application/templates/cronjob.yaml
@@ -54,12 +54,8 @@ spec:
           annotations: {{ toYaml . | nindent 12 }}
           {{- end }}
         spec:
-          {{- if $.Values.rbac.enabled }}
-          {{- if $.Values.rbac.serviceAccount.name }}
-          serviceAccountName: {{ $.Values.rbac.serviceAccount.name }}
-            {{- else }}
-          serviceAccountName: {{ template "application.name" $ }}
-          {{- end }}
+          {{- if and $.Values.rbac.enabled $.Values.rbac.serviceAccount.enabled }}
+          serviceAccountName: {{ default (include "application.name" $) $.Values.rbac.serviceAccount.name }}
           {{- end }}
           containers:
           - name: {{ $name }}

diff --git a/application/templates/deployment.yaml b/application/templates/deployment.yaml
@@ -308,12 +308,8 @@ spec:
         {{- end }}
         {{- end }}
       {{- end }}
-      {{- if .Values.rbac.serviceAccount.enabled }}
-      {{- if .Values.rbac.serviceAccount.name }}
-      serviceAccountName: {{ .Values.rbac.serviceAccount.name }}
-      {{- else }}
-      serviceAccountName: {{ template "application.name" $ }}
-      {{- end }}
+      {{- if and .Values.rbac.enabled .Values.rbac.serviceAccount.enabled }}
+      serviceAccountName: {{ default (include "application.name" .) .Values.rbac.serviceAccount.name }}
       {{- end }}
       {{- if .Values.deployment.hostNetwork }}
       hostNetwork: {{ .Values.deployment.hostNetwork }}

diff --git a/application/templates/job.yaml b/application/templates/job.yaml
@@ -37,12 +37,8 @@ spec:
       annotations: {{ toYaml . | nindent 8 }}
       {{- end }}
     spec:
-      {{- if $.Values.rbac.enabled }}
-      {{- if $.Values.rbac.serviceAccount.name }}
-      serviceAccountName: {{ $.Values.rbac.serviceAccount.name }}
-        {{- else }}
-      serviceAccountName: {{ template "application.name" $ }}
-      {{- end }}
+      {{- if and $.Values.rbac.enabled $.Values.rbac.serviceAccount.enabled }}
+      serviceAccountName: {{ default (include "application.name" $) $.Values.rbac.serviceAccount.name }}
       {{- end }}
       containers:
       - name: {{ $name }}