Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove default values for rollingUpdate #360

Merged
merged 3 commits into from
Dec 31, 2024
Merged

fix: Remove default values for rollingUpdate #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b2c488
Remove default values for rollingUpdate
arielly-parussulo Nov 13, 2024
4692761
fix: remove docs comments for rollingUpdate
aslafy-z Nov 25, 2024
d0e4ef3
Update README.md
aslafy-z Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ helm delete --namespace test my-application
| deployment.annotations | object | `nil` | Annotations for Deployment. |
| deployment.additionalPodAnnotations | object | `nil` | Additional pod annotations. |
| deployment.strategy.type | string | `"RollingUpdate"` | Type of deployment strategy. |
| deployment.strategy.rollingUpdate.maxUnavailable | string | `"25%"` | Max unavailable pods during update. |
| deployment.strategy.rollingUpdate.maxSurge | string | `"25%"` | Max surge pods during update. |
| deployment.reloadOnChange | bool | `true` | Reload deployment if attached Secret/ConfigMap changes. |
| deployment.nodeSelector | object | `nil` | Select the node where the pods should be scheduled. |
| deployment.hostAliases | list | `nil` | Add host aliases to the pods. |
Expand Down
10 changes: 3 additions & 7 deletions application/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,9 @@ deployment:
# -- (string) Type of deployment strategy.
# @section -- Deployment Parameters
type: RollingUpdate
rollingUpdate:
# -- (string) Max unavailable pods during update.
# @section -- Deployment Parameters
maxUnavailable: 25%
# -- (string) Max surge pods during update.
# @section -- Deployment Parameters
maxSurge: 25%
# rollingUpdate:
# maxUnavailable: 25%
# maxSurge: 25%
# -- (bool) Reload deployment if attached Secret/ConfigMap changes.
# @section -- Deployment Parameters
reloadOnChange: true
Expand Down
Loading