Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dnsPolicy support to Deployment #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomjo
Copy link

@tomjo tomjo commented Nov 24, 2024

Fixes #365

If wanted, I can also add it to job and cronjob but perhaps then support for dnsConfig should be added there as well?

@tomjo tomjo requested a review from aslafy-z as a code owner November 24, 2024 22:02
@aslafy-z
Copy link
Collaborator

I think adding dnsConfig too would be a nice addition. Also, I would prefer them to be added to deployments, jobs and cronjob at the same time. Can you do these changes?
Please use make build-docs to update the readme file.

@tomjo tomjo force-pushed the feat/dns-policy branch 2 times, most recently from 202b6cb to f6960fe Compare November 24, 2024 22:33
@tomjo
Copy link
Author

tomjo commented Nov 24, 2024

I added dnsConfig to Job and CronJob as well as dnsPolicy to Deployment, Job and CronJob. Readme now updated using make.

application/values.yaml Outdated Show resolved Hide resolved
application/values.yaml Show resolved Hide resolved
@tomjo tomjo force-pushed the feat/dns-policy branch 4 times, most recently from 2e14b12 to 109e46c Compare November 24, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dnsPolicy support
2 participants